FIX support SSH CA user signed keys in ssh_agent#1
FIX support SSH CA user signed keys in ssh_agent#1auphofBSF wants to merge 1 commit intoTimWolla:ssh-certificatefrom
Conversation
|
Hi @auphofBSF. Thank you for the contribution and the interest in my SSH CA patches. However I don't feel confident integrating this PR into my branch.
Additionally I can't really test your changes, the original PR was written to fit my use case and I intentionally made a minimally invasive patch to improve the chances for merging. Unfortunately it already looks like this is not going to happen any time soon and taking your commit probably would not improve chances. I suggest to either hold off your patch until my PR is merged or to create a concurring PR containing both my commit and your addition. |
|
Thanks for your comments @TimWolla , I knew It would not go through but put it there as documentation for people like myself who are trying to use SSH certificates via the ssh-agent. I will raise it as an issue on mscdex:ssh2 |
2 participants
PR mscdex#808 publickey support for SSH certificates is great but I found it was failing with when the keys and signed certificates where in ssh_agent
The changes I propose in this PR enable signed certs
ssh-rsa-cert-v01@openssh.comto be correctly handled by the SSH client when retrieved from SSH_AGENT. This is the default certificate type returned by Hashicorp Vault SSH CA signing.This PR does not handle the multitude of possible cert types and robustly handle the errors if this where the case. I don't like submitting something not fully complete but I am a Newbie to this wonderful world of PublicKey and Security so would hope someone with suitable experience would more confidently and robustly fill in the general cases. Thansk to @TimWolla for original work implementing Publickey Certificate support and hope @mscdex will review and merge soon